feat(FR-871): improve visibility of committed container names#3544
Merged
graphite-app[bot] merged 1 commit intoApr 21, 2025
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.17% | 409/9808 |
| 🔴 | Branches | 3.54% | 240/6787 |
| 🔴 | Functions | 2.54% | 79/3114 |
| 🔴 | Lines | 4.11% | 394/9592 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 69b043b
Merge activity
|
Resolves #3543 ([FR-871](https://lablup.atlassian.net/browse/FR-871)) # Fix tag display logic to show customized tags properly This PR modifies the tag display logic across multiple components to ensure customized tags are properly displayed. The key changes include: 1. Added a condition to show tags when `isCustomized` is true, regardless of the alias equality check 2. Updated `ImageTags` component to properly pass props to the React.Fragment These changes ensure that customized tags are consistently displayed in the UI, fixing an issue where they might be filtered out incorrectly. - My Environment  - Session launcher  - Images  **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup): 10.82.230.49 - [x] Minimum requirements to check during review: check customized name in My Environment, Session Launcher, Images page. - [ ] Test case(s) to demonstrate the difference of before/after [FR-871]: https://lablup.atlassian.net/browse/FR-871?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
Bot
force-pushed
the
feat_FR-871_/improve-visibility-of-committed-container-names
branch
from
ee2251a to
69b043b
Compare
graphite-app
Bot
deleted the
feat_FR-871_/improve-visibility-of-committed-container-names
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3543 (FR-871)
Fix tag display logic to show customized tags properly
This PR modifies the tag display logic across multiple components to ensure customized tags are properly displayed. The key changes include:
isCustomizedis true, regardless of the alias equality checkImageTagscomponent to properly pass props to the React.FragmentThese changes ensure that customized tags are consistently displayed in the UI, fixing an issue where they might be filtered out incorrectly.
Checklist: